[Mellanox] Add python3 support for Mellanox platform API#6175
Merged
jleveque merged 5 commits intosonic-net:masterfrom Dec 11, 2020
Merged
[Mellanox] Add python3 support for Mellanox platform API#6175jleveque merged 5 commits intosonic-net:masterfrom
jleveque merged 5 commits intosonic-net:masterfrom
Conversation
Closed
3 tasks
jleveque
suggested changes
Dec 10, 2020
Contributor
|
@Junchao-Mellanox: Once this PR is merged, are we good to merge #5886? |
Collaborator
Author
@keboliu I suppose you are working on the system health python3 migration, could you answer this comment? |
jleveque
suggested changes
Dec 11, 2020
jleveque
approved these changes
Dec 11, 2020
Collaborator
generally, system-health has a dependency on platform API python3 lib, and when it ready system-health should be able to run, however, I see that system-health itself still has some issue in terms of string handling. left comments in another PR #5886 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
python2 is end of life and SONiC is going to support python3. This PR is going to support:
- How I did it
- How to verify it
Run platform regressions on a few platforms
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)